Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(1637): create timeout and retry for md url validation #1638

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix(1637): create timeout and retry for md url validation #1638

merged 1 commit into from
Apr 2, 2024

Conversation

w3cj
Copy link
Contributor

@w3cj w3cj commented Apr 2, 2024

  • Cancels URL validation requests that take longer than 2 seconds
  • Retries requests with a GET instead of HEAD in case of weird server behavior

@vercel Vercel
Copy link

vercel bot commented Apr 2, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
syntax-website ✅ Ready (Inspect) Visit Preview Apr 2, 2024 6:12pm

@w3cj
Copy link
Contributor Author

w3cj commented Apr 2, 2024

Fixes bug that appeared in #1637

stolinski
stolinski approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@stolinski stolinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@stolinski stolinski merged commit 3a6215a into main Apr 2, 2024
2 of 3 checks passed
@stolinski stolinski deleted the fix-url-validation branch April 2, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stolinski stolinski stolinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@w3cj @stolinski