feature/metrics #21
Merged
feature/metrics #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hilly12
commented
May 4, 2021
|
|
||
| xx, yy = np.meshgrid(space, space) | ||
| distance_space = np.abs(xx - yy) | ||
|
|
There was a problem hiding this comment.
Not sure if we need to normalize the distance space
Hilly12
commented
May 4, 2021
Hilly12
commented
May 4, 2021
| g_counts = df[pred].groupby(target_attr)[target_attr].aggregate(Count="count")["Count"].to_dict() | ||
|
|
||
| plt.plot(g_counts.keys(), g_counts.values()) | ||
|
|
There was a problem hiding this comment.
At the moment the curves plot the raw data. It may make more sense to bin before drawing the curves.
Hilly12
commented
May 4, 2021
|
|
||
| from . import utils | ||
|
|
||
|
|
There was a problem hiding this comment.
Might be worth adding a 'normalize' keyword which plots the pdf instead of the target attr distribution, or maybe its worth having a different method to plot pdfs.
jamied157
reviewed
May 5, 2021
| @@ -0,0 +1,112 @@ | |||
| from typing import Any, Dict, List | |||
There was a problem hiding this comment.
It might have been good to separate this work into another PR, that way we keep the goals of each PR isolated to a single issue.
jamied157
reviewed
May 5, 2021
jamied157
reviewed
May 5, 2021
jamied157
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9 #17 #18 #25