Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics Refactor #54

Closed
wants to merge 50 commits into from
Closed

Metrics Refactor #54

wants to merge 50 commits into from

Conversation

bogdansurdu
Copy link
Contributor

This PR will make the following changes:

NEW MODULES

  • Create and move correlation metrics to the module (correlation_metrics.py) in the fairlens.metrics package. Metrics will now be shared between heatmap.py and the proxy detection in 'correlation.py' from the detection module
  • Create and move statistical distance metrics to the module (distance_metrics.py) in the fairlens.metrics package
  • Add statistical distance base classes (i.e. ContinuousDistanceMetric) to distance_metrics.py as well

CHANGED MODULES

  • Remove statistical distance implementations from the old metrics.py module and leave only auto_distance and stat_distance as the main functionality used by the fairness scorer
  • Rename old metrics.py module to distance.py to better reflect its purpose
  • Restructure test_metrics.py and test_distance.py imports to point to the new location of the metrics

REMOVED MODULES

  • Remove old distance.py module (which contained the statistical distance abstract and base classes)

@bogdansurdu bogdansurdu self-assigned this Jul 15, 2021
@bogdansurdu bogdansurdu added the type:enhancement New feature or request label Jul 15, 2021
@bogdansurdu bogdansurdu marked this pull request as draft July 15, 2021 13:53
@simonhkswan simonhkswan added the status:wontfix This will not be worked on label Aug 3, 2021
@Hilly12 Hilly12 changed the base branch from main to demo August 3, 2021 14:58
@Hilly12 Hilly12 changed the base branch from demo to main August 3, 2021 14:58
@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rob-tay
Copy link
Contributor

rob-tay commented Aug 6, 2021

Closing as this has been superseded by #67 #69

@rob-tay rob-tay closed this Aug 6, 2021
@rob-tay rob-tay deleted the enhancement/metric-refactor branch August 6, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:wontfix This will not be worked on type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants