Add correlation heatmap functions #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
simonhkswan
commented
Aug 3, 2021
•
simonhkswan
commented
- add boolean Kruskal-Wallis H Test for proxy detection
- update non-linear metrics to suppress some warnings (so they can be used in docs)
- fix of compute_correlation_metrics
- addition of helper function for compute_correlation_metrics to use in list comprehensions
- addition of multiprocessing to compute_correlation_metrics to increase speed
- update of two_column_heatmap type signature and docstring
- scale heatmap size based on input
simonhkswan
force-pushed
the
heatmap-update
branch
3 times, most recently
from
8e43b56
to
966199d
Compare
simonhkswan
force-pushed
the
heatmap-update
branch
from
966199d
to
60d54b2
Compare
This reverts commit 60d54b2.
rob-tay
reviewed
Aug 5, 2021
rob-tay
suggested changes
Aug 6, 2021
| Args: | ||
|
|
There was a problem hiding this comment.
Don't need space after "Args"
Suggested change
| @@ -22,8 +22,8 @@ def find_sensitive_correlations( | |||
| """Looks at the columns that are not considered to be immediately sensitive and finds if any is strongly | |||
| correlated with a sensitive column, specifying both the sensitive column name and the sensitive category | |||
| it is a part of. | |||
|
|
|||
There was a problem hiding this comment.
Need a space here before "Args"
| @@ -91,8 +91,8 @@ def find_column_correlation( | |||
| or the column corresponding to the given name. | |||
| If matches are found, a list containing the correlated | |||
| column names and its associated sensitive category, respectively, is returned. | |||
|
|
|||
There was a problem hiding this comment.
Need a space here before "Args"
| Args: | ||
|
|
There was a problem hiding this comment.
Don't need space after "Args"
Suggested change
|
Kudos, SonarCloud Quality Gate passed!
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.