Print error message when failing to load mtl file #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not an ideal solution, since we don't want to do I/O at all. But until we have a callback to load mtl files, this way the user can at least get the real error message to diagnose the problem.
|
Thanks!
Yes, ideal solution will be providing callback function to report error. Additional PR is welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not an ideal solution, since we don't want to do I/O at all.
But until we have a callback to load mtl files as described in #4 , this way the user can at least get the real error message to diagnose the problem. (Which in most cases is an incorrect relative path to the material file, which would be solved by the solution proposed in #4 as well.)
This unfortunately introduces an additional dependency on
<errno.h>, so this change might not be favorable.