Various build improvements #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consult pkg-config to find glfw3. On my distribution, the correct option is just -lglfw. I'm not sure about Darwin here, so I didn't touch it. Make the viewer compile on both GCC and Clang by removing Clang-only options like -Weverything and replacing them with more common ones. Note that conversion warnings have been disabled; they can be re-enabled with -Wconversion. trackball.c triggers several of them, but they don't seem like a problem. viewer.o depends on trackball.h, update the Makefile accordingly. The pragmas to ignore -Weverything have been removed, as this option is no longer used. main was missing a return statement.
Since acutest.h is C99, we never build tinyobj_loader_c.h with -ansi (or any warning flags). Create a new goal to build tinyobj_loader_c.h with -ansi and a strict set of warnings.
|
Awesome! merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please look at individual commits for an explanation.
Even though in #6 it was pretty much decided to move to C99, I decided to keep C89 compatibility for now since it was not hard to fix.
Note that the size_t commit has not been tested very well.