Skip to content

Commit

Permalink
Merge bitcoin#25937: test: add coverage for rpc error when trying to …
Browse files Browse the repository at this point in the history
…rescan beyond pruned data

cca4f82 test: add coverage for rpc error when trying to rescan beyond pruned data (brunoerg)

Pull request description:

  This PR adds test coverage for the following rpc error:
  https://github.com/bitcoin/bitcoin/blob/15692e2641592394bdd4da0a7c2d371de8e576dd/src/wallet/rpc/transactions.cpp#L896-L899

ACKs for top commit:
  MarcoFalke:
    lgtm ACK cca4f82
  aureleoules:
    ACK cca4f82

Tree-SHA512: 724a055e9f6cddf1935699e8769015115f24f6485a0bd87e8660072ee44a15c1bddfdda848acc101ea7184b7e65a33b5b0d80b563d2ba3ecdab7a631378d6476
  • Loading branch information
fanquake authored and sidhujag committed Apr 28, 2023
1 parent 031c0b2 commit 037622c
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions test/functional/feature_pruning.py
Expand Up @@ -136,6 +136,10 @@ def test_invalid_command_line_options(self):
extra_args=['-prune=550', '-reindex-chainstate'],
)

def test_rescan_blockchain(self):
self.restart_node(0, ["-prune=550"])
assert_raises_rpc_error(-1, "Can't rescan beyond pruned data. Use RPC call getblockchaininfo to determine your pruned height.", self.nodes[0].rescanblockchain)

def test_height_min(self):
assert os.path.isfile(os.path.join(self.prunedir, "blk00000.dat")), "blk00000.dat is missing, pruning too early"
self.log.info("Success")
Expand Down Expand Up @@ -470,6 +474,9 @@ def run_test(self):
self.log.info("Test wallet re-scan")
self.wallet_test()

self.log.info("Test it's not possible to rescan beyond pruned data")
self.test_rescan_blockchain()

self.log.info("Test invalid pruning command line options")
self.test_invalid_command_line_options()
# SYSCOIN
Expand Down

0 comments on commit 037622c

Please sign in to comment.