Skip to content

Commit

Permalink
Merge bitcoin#21447: Always add -daemonwait to known command line arg…
Browse files Browse the repository at this point in the history
…uments

4d008f9 Always add -daemonwait to known command line arguments (Hennadii Stepanov)

Pull request description:

  This is a follow up of bitcoin#21007.

  When `AC_CHECK_DECLS([fork])` fails:

  - on master (8e65320):
  ```
  $ src/bitcoind -daemonwait
  Error: Error parsing command line arguments: Invalid parameter -daemonwait

  ```

  - with this PR:
  ```
  $ src/bitcoind -daemonwait
  Error: -daemon is not supported on this operating system

  ```

ACKs for top commit:
  laanwj:
    Code review ACK 4d008f9

Tree-SHA512: 7fcb5e9d76958adcf57e04fa74bd2a98d62459d81a3c57a97bd74c346cbf47c53e560a15455fb024e912c3b44e8487a83499e993b282871ba069953e665d88a9
  • Loading branch information
laanwj authored and jagdeep sidhu committed Mar 16, 2021
1 parent 4ec4c4b commit 24c1d91
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/init.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -713,6 +713,7 @@ void SetupServerArgs(NodeContext& node)
argsman.AddArg("-daemonwait", strprintf("Wait for initialization to be finished before exiting. This implies -daemon (default: %d)", DEFAULT_DAEMONWAIT), ArgsManager::ALLOW_BOOL, OptionsCategory::OPTIONS);
#else
hidden_args.emplace_back("-daemon");
hidden_args.emplace_back("-daemonwait");
#endif

// Add the hidden options
Expand Down

0 comments on commit 24c1d91

Please sign in to comment.