Merge bitcoin#24687: test: Check an invalid -i2psam will raise an ini…

…t error

45e67b2 test: invalid -i2psam will raise an init error (brunoerg)

Pull request description:

  This PR adds test coverage (at `feature_proxy.py`) for the following init error:

  https://github.com/bitcoin/bitcoin/blob/2f0f056e08cd5a1435120592a9ecd212fcdb915b/src/init.cpp#L1791

  It starts the node with an invalid -i2psam (`-i2psam=invalidhere`) and test if it raises an error when initializing.

ACKs for top commit:
  dunxen:
    Code review ACK 45e67b2

Tree-SHA512: b24e3f6e7a9316b9ebc0b6c8bcf1315faff60a9e258d7bb3dbeb9f6695a728bb3083aea2f81114072fe13822bfca34d4a0f44f229825f7c97a81619d810010c0

test/functional/feature_proxy.py

@@ -33,6 +33,7 @@
 
 - Test passing invalid -proxy
 - Test passing invalid -onion
+- Test passing invalid -i2psam
 - Test passing -onlynet=onion without -proxy or -onion
 - Test passing -onlynet=onion with -onion=0 and with -noonion
 """
@@ -329,6 +330,11 @@ def networks_dict(d):
         msg = "Error: Invalid -onion address or hostname: 'xyz:abc'"
         self.nodes[1].assert_start_raises_init_error(expected_msg=msg)
 
+        self.log.info("Test passing invalid -i2psam raises expected init error")
+        self.nodes[1].extra_args = ["-i2psam=def:xyz"]
+        msg = "Error: Invalid -i2psam address or hostname: 'def:xyz'"
+        self.nodes[1].assert_start_raises_init_error(expected_msg=msg)
+
         msg = (
             "Error: Outbound connections restricted to Tor (-onlynet=onion) but "
             "the proxy for reaching the Tor network is not provided (no -proxy= "