Fix SCL block parameter substitution #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a quoted character, transitioning into CLS_WITHIN_STRING is not enough, because another quote or "string end" character may follow. Signed-off-by: László Várady <laszlo.varady93@gmail.com>
|
@jszigetvari Could you try this patch with your original config, please? |
|
Build SUCCESS |
|
@kira-syslogng retest this please |
|
Build SUCCESS |
|
@MrAnno As far as I could check, my test config, that produced the error eariler now passes the syntax validation. |
|
@jszigetvari Thanks for the test! |
|
@kira-syslogng retest this please |
|
Build SUCCESS |
gaborznagy
approved these changes
Sep 16, 2019
MrAnno
added a commit
to MrAnno/syslog-ng
that referenced
this pull request
Oct 19, 2019
After fixing the SCL parameter substitution in syslog-ng#2901, the Telegram destination has stopped working. The type of the use-system-cert-store() option should be yes/no, strings are not accepted. Signed-off-by: László Várady <laszlo.varady@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a quoted character, transitioning into
CLS_WITHIN_STRINGis notenough, because another quote or "string end" character may follow.
Here is the state machine of
_track_string_state(), the red lines were missing.Fixes #2879