scl: add qbittorrent() and pihole-ftl() sources
#4760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Severities are based on: https://github.com/qbittorrent/qBittorrent/blob/8dcc734df562885131dbd0c2cc4ec31e24361559/src/app/filelogger.cpp#L131 Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
See: https://github.com/pi-hole/FTL The FTL (Faster Than Light) logs are the logs which can be found in the "Tools" / "Pi-hole diagnosis" menu. The severity of the logs are not really formatted coherently, I have applied this regexp to find the current set of severities: $ git grep -Eho 'logg\("[a-zA-Z]+:' | sort | uniq logg("API: logg("APR: logg("Backtrace: logg("dbquery: logg("DEBUG: logg("ERR: logg("Error: logg("ERROR: logg("Executing: logg("FATAL: logg("HINT: logg("INFO: logg("Interfaces: logg("Notice: logg("Received: logg("Regex: logg("Script: logg("SQL: logg("WARN: logg("Warning: logg("WARNING: Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
Signed-off-by: Attila Szakacs <szakacs.attila96@gmail.com>
bazsi
reviewed
Dec 23, 2023
| rewrite { set-severity("info"); }; | ||
| } elif (match("^(DEBUG):$" value("2"))) { | ||
| rewrite { set-severity("debug"); }; | ||
| } else {}; |
There was a problem hiding this comment.
it would make sense to write a severity-parser() that can be parametrized with patterns but uses a sensible default so that we don't need to write similar constructs.
Also, you should not need the dangling else{} at the end.
There was a problem hiding this comment.
The severity-parser() is just an idea, it's not a dependency of this PR.
Also, this could be rewritten as:
if ("$2" == "FATAL") {
} elif ("$2" == "ERR") {
although this does not support regexps.
Merged
|
Some pointers for qBittorrent logs: |
MrAnno
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.