Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3: GCS compatibility #4956

Merged

Commits on May 13, 2024

  1. s3: omit empty marker params from api calls

    Google Cloud Storage's implementation of the S3 API responds the
    following error to a requests like
    "GET /bucket?uploads&prefix=p&key-marker=&upload-id-marker=":
    
    <Error>
    	<Code>InvalidArgument</Code>
    	<Message>Invalid argument.</Message>
    	<Details>Invalid upload ID marker: </Details>
    </Error>
    
    Specify these query parameters only in subsequent requests after we get
    a truncated response.
    
    Signed-off-by: Mate Ory <mate.ory@axoflow.com>
    orymate committed May 13, 2024
    Configuration menu
    Copy the full SHA
    1d9061b View commit details
    Browse the repository at this point in the history