Several improvement related to Aurora #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new query now handles also replicas where REPLICA_LAG_IN_MILLISECONDS == 0 . This commit also add comments to track the changes in this query.
From 50 snapshots to 150 snapshots
This commits solves 2 issues: 1. ignore decommissioned or renamed nodes, see #3484 2. during a failover, the former writer (still reporting MASTER_SESSION_ID) is not considered a writer if it is not the last updated
|
retest this please |
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve various issues.
a) it handles also replicas where REPLICA_LAG_IN_MILLISECONDS == 0
b) ignore decommissioned or renamed nodes, see #3484
c) during a failover, the former writer (still reporting MASTER_SESSION_ID) is not considered a writer if it is not the last updated
d) increases the amount of entries stored in mysql_server_aws_aurora_log from 50 to 150 snapshots (more history)
This PR also removed unused code