Solve bug #3749 and improve testing #3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MySQL_Connection::IsActiveTransaction: in the past we were incorrectly checking STATUS_MYSQL_CONNECTION_HAS_SAVEPOINT and returning true in case there were any savepoint. Although flag STATUS_MYSQL_CONNECTION_HAS_SAVEPOINT was not reset in case of no transaction, thus the check was incorrect. We can ignore STATUS_MYSQL_CONNECTION_HAS_SAVEPOINT for multiplexing purpose in IsActiveTransaction() because it is also checked in MultiplexDisabled()
Because of MySQL bug https://bugs.mysql.com/bug.php?id=107875 , autocommit=0 can "create a transaction" even if SERVER_STATUS_IN_TRANS is not set. This means that a SAVEPOINT can be created in a "transaction" created with autocommit=0 but without SERVER_STATUS_IN_TRANS . This commit takes also care of scenarios when autocommit=0 was switched back to autocommit=1 when a SELECT was executed while variable mysql-enforce_autocommit_on_reads was false. MySQL_Session::NumActiveTransactions() now accepts a flag to check for savepoints.
Another edge case due to MySQL bug https://bugs.mysql.com/bug.php?id=107875 related to autocommit=0 and SAVEPOINT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MySQL_Connection::IsActiveTransaction:
in the past we were incorrectly checking STATUS_MYSQL_CONNECTION_HAS_SAVEPOINT
and returning true in case there were any savepoint.
Although flag STATUS_MYSQL_CONNECTION_HAS_SAVEPOINT was not reset in
case of no transaction, thus the check was incorrect.
We can ignore STATUS_MYSQL_CONNECTION_HAS_SAVEPOINT for multiplexing
purpose in IsActiveTransaction() because it is also checked
in MultiplexDisabled()