Integrate gbit framework for instruction testing #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Jan 6, 2021
jserv
reviewed
Jan 6, 2021
jserv
reviewed
Jan 6, 2021
Rsysz
force-pushed
the
AddInstructionTester
branch
from
cf3f35b
to
4f73eda
Compare
jserv
reviewed
Jan 6, 2021
jserv
reviewed
Jan 6, 2021
jserv
reviewed
Jan 6, 2021
jserv
reviewed
Jan 6, 2021
jserv
reviewed
Jan 6, 2021
jserv
reviewed
Jan 6, 2021
Rsysz
force-pushed
the
AddInstructionTester
branch
2 times, most recently
from
c4cb112
to
193508b
Compare
jserv
changed the title
jserv
reviewed
Jan 7, 2021
jserv
reviewed
Jan 7, 2021
jserv
reviewed
Jan 7, 2021
jserv
reviewed
Jan 7, 2021
jserv
reviewed
Jan 7, 2021
jserv
reviewed
Jan 7, 2021
Rsysz
force-pushed
the
AddInstructionTester
branch
from
193508b
to
3a31ff7
Compare
jserv
reviewed
Jan 7, 2021
Rsysz
force-pushed
the
AddInstructionTester
branch
from
3a31ff7
to
f77830b
Compare
jserv
reviewed
Jan 8, 2021
Rsysz
force-pushed
the
AddInstructionTester
branch
2 times, most recently
from
1e4a95a
to
2ad17e3
Compare
jserv
reviewed
Jan 8, 2021
jserv
reviewed
Jan 8, 2021
jserv
reviewed
Jan 8, 2021
Rsysz
force-pushed
the
AddInstructionTester
branch
from
2ad17e3
to
98753d0
Compare
jserv
reviewed
Jan 8, 2021
jserv
reviewed
Jan 8, 2021
Rsysz
force-pushed
the
AddInstructionTester
branch
from
98753d0
to
f3ac557
Compare
jserv
reviewed
Jan 9, 2021
jserv
reviewed
Jan 9, 2021
jserv
reviewed
Jan 9, 2021
jserv
reviewed
Jan 9, 2021
Rsysz
force-pushed
the
AddInstructionTester
branch
from
f3ac557
to
0c23716
Compare
|
Done? |
jserv
reviewed
Jan 25, 2021
| return 0xFF; | ||
| if (addr < instruction_mem_size) | ||
| return instruction_mem[addr]; | ||
| return 0xaa; |
There was a problem hiding this comment.
Why 0xaa? You have to explain.
jserv
reviewed
Jan 25, 2021
Rsysz
force-pushed
the
AddInstructionTester
branch
from
0c23716
to
196aab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting for review and modify ~