Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check the by-id path for a USB stick #24

Closed
wants to merge 8 commits into from
Closed

check the by-id path for a USB stick #24

wants to merge 8 commits into from

Conversation

TheRsKing
Copy link
Contributor

@TheRsKing TheRsKing commented May 31, 2024

would solve the : problem since the unix path does not contain :

not 100% sure if the code is correct

@TheRsKing TheRsKing marked this pull request as draft May 31, 2024 12:16
@TheRsKing
Copy link
Contributor Author

TheRsKing commented May 31, 2024

the recognition of the :0 does work but not the fallback to the unix path

Help appreciated

@happymab
Copy link
Contributor

happymab commented Jun 1, 2024

This worked in my tests:
TIK_INSTALL_DEVICE="$(readlink -f "/dev/disk/"${disk_id}"/"${result}"")"

note that it's slightly different than what I posted in the Matrix chat. It uses the ${disk_id} variable that is available.

I think this will work for the USB-disk-ids case only, not for the fallback that is in the previous code. Therefore you should probably use a separate if check for the USB case.

@TheRsKing
Copy link
Contributor Author

Thanks!

@TheRsKing TheRsKing marked this pull request as ready for review June 1, 2024 17:09
@happymab
Copy link
Contributor

happymab commented Jun 1, 2024

Hmm, I thought your if check should be separate, outside the other fallback if clause. Didn't think it through though and didn't test myself.

@TheRsKing TheRsKing marked this pull request as draft June 1, 2024 17:36
@TheRsKing TheRsKing marked this pull request as ready for review June 2, 2024 00:29
@TheRsKing TheRsKing closed this Jun 2, 2024
@TheRsKing
Copy link
Contributor Author

code unnecessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants