Fixed potential NullPointerExceptions for TypeDiscoverer.getComponent…

…Type() and getMapValueType().
systay · Aug 19, 2011 · 307993a · 307993a
1 parent c71f268
commit 307993a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/spring-data-commons-core/src/main/java/org/springframework/data/util/TypeDiscoverer.java b/spring-data-commons-core/src/main/java/org/springframework/data/util/TypeDiscoverer.java
@@ -255,7 +255,12 @@ public TypeInformation<?> getMapValueType() {
 			return createInfo(parameterizedType.getActualTypeArguments()[1]);
 		} 
 
-		return createInfo(GenericTypeResolver.resolveTypeArguments(getType(), Map.class)[1]);
+		return getTypeArgument(getType(), Map.class, 1);
+	}
+
+	private TypeInformation<?> getTypeArgument(Class<?> type, Class<?> bound, int index) {
+		Class<?>[] arguments = GenericTypeResolver.resolveTypeArguments(type, bound);
+		return arguments == null ? null : createInfo(arguments[index]);
 	}
 
 	/* (non-Javadoc)
@@ -284,11 +289,11 @@ public TypeInformation<?> getComponentType() {
 		Class<S> rawType = getType();
 
 		if (isMap()) {
-			return createInfo(GenericTypeResolver.resolveTypeArguments(rawType, Map.class)[0]);
+			return getTypeArgument(rawType, Map.class, 0);
 		}
 
 		if (Iterable.class.isAssignableFrom(rawType)) {
-			return createInfo(GenericTypeResolver.resolveTypeArguments(rawType, Iterable.class)[0]);
+			return getTypeArgument(rawType, Iterable.class, 0);
 		}
 
 		if (rawType.isArray()) {

diff --git a/...ata-commons-core/src/test/java/org/springframework/data/util/TypeDiscovererUnitTests.java b/...ata-commons-core/src/test/java/org/springframework/data/util/TypeDiscovererUnitTests.java
@@ -126,6 +126,14 @@ public void discoveresConstructorParameterTypesCorrectly() throws NoSuchMethodEx
 		assertThat(types.get(0).getComponentType().getType(), is(equalTo((Class) String.class)));
 	}
 
+	@Test
+	@SuppressWarnings("rawtypes")
+	public void returnsNullForComponentAndValueTypesForRawMaps() {
+		TypeDiscoverer<Map> discoverer = new TypeDiscoverer<Map>(Map.class, null);
+		assertThat(discoverer.getComponentType(), is(nullValue()));
+		assertThat(discoverer.getMapValueType(), is(nullValue()));
+	}
+
 	class SelfReferencing {
 
 		Map<String, SelfReferencingMap> parent;