DATACMNS-206 - Guard against PropertyDescriptor being null.

Added guards to PropertyDescriptor access to prevent NullPointerExceptions in cases it is not given in the first place. Polished JavaDoc for test case.
systay · Jul 31, 2012 · f532404 · f532404
1 parent fc57f60
commit f532404
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/...core/src/main/java/org/springframework/data/mapping/model/AbstractPersistentProperty.java b/...core/src/main/java/org/springframework/data/mapping/model/AbstractPersistentProperty.java
@@ -148,6 +148,10 @@ public PropertyDescriptor getPropertyDescriptor() {
 	 */
 	public Method getGetter() {
 
+		if (propertyDescriptor == null) {
+			return null;
+		}
+
 		Method getter = propertyDescriptor.getReadMethod();
 
 		if (getter == null) {
@@ -163,6 +167,10 @@ public Method getGetter() {
 	 */
 	public Method getSetter() {
 
+		if (propertyDescriptor == null) {
+			return null;
+		}
+
 		Method setter = propertyDescriptor.getWriteMethod();
 
 		if (setter == null) {

diff --git a/...test/java/org/springframework/data/mapping/model/AbstractPersistentPropertyUnitTests.java b/...test/java/org/springframework/data/mapping/model/AbstractPersistentPropertyUnitTests.java
@@ -125,6 +125,9 @@ public void doesNotConsiderJavaTransientFieldsTransient() {
 		assertThat(property.isTransient(), is(false));
 	}
 
+	/**
+	 * @see DATACMNS-206
+	 */
 	@Test
 	public void findsSimpleGettersAndASetters() {
 
@@ -136,6 +139,9 @@ public void findsSimpleGettersAndASetters() {
 		assertThat(property.getSetter(), is(notNullValue()));
 	}
 
+	/**
+	 * @see DATACMNS-206
+	 */
 	@Test
 	public void doesNotUseInvalidGettersAndASetters() {
 
@@ -147,6 +153,9 @@ public void doesNotUseInvalidGettersAndASetters() {
 		assertThat(property.getSetter(), is(nullValue()));
 	}
 
+	/**
+	 * @see DATACMNS-206
+	 */
 	@Test
 	public void usesCustomGetter() {
 
@@ -158,6 +167,9 @@ public void usesCustomGetter() {
 		assertThat(property.getSetter(), is(nullValue()));
 	}
 
+	/**
+	 * @see DATACMNS-206
+	 */
 	@Test
 	public void usesCustomSetter() {
 
@@ -169,6 +181,20 @@ public void usesCustomSetter() {
 		assertThat(property.getSetter(), is(notNullValue()));
 	}
 
+	/**
+	 * @see DATACMNS-206
+	 */
+	@Test
+	public void returnsNullGetterAndSetterIfNoPropertyDescriptorGiven() {
+
+		Field field = ReflectionUtils.findField(AccessorTestClass.class, "id");
+		PersistentProperty<SamplePersistentProperty> property = new SamplePersistentProperty(field, null, entity,
+				typeHolder);
+
+		assertThat(property.getGetter(), is(nullValue()));
+		assertThat(property.getSetter(), is(nullValue()));
+	}
+
 	private static PropertyDescriptor getPropertyDescriptor(Class<?> type, String propertyName) {
 
 		try {