Propose collapsing dimensions/lengths into sizes key
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
+1 for |
fk
added a commit
to gatsbyjs/gatsby
that referenced
this pull request
Apr 4, 2019
KyleAMathews
pushed a commit
to gatsbyjs/gatsby
that referenced
this pull request
Apr 4, 2019
…tSizes, dimensions -> sizes) (#13107) * Rename presets.scale to .fontSizes https://system-ui.com/theme * Rename presets.dimensions to .sizes Ref. system-ui/theme-specification#2
|
Merging this in because it seems like generally a good direction based on feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A thought occurred to me the other day that it might make more sense to collapse width and height properties into a single field, similar to how
spaceis currently treated. It seems like the same values could be reused for different properties. This is similar to something @ianstormtaylor proposed on twitter with lengths.Possible, alternative names to consider:
sizesdimensionslengthsIt's worth noting that
<length>has a specific meaning in CSS that is slightly different than the possible values here (e.g. percentages), which is part of the reason for usingsizesin this PR