Merge pull request #2058 from appsparkler/patch-1

chore: update style for core Select component
system-ui · Aug 8, 2022 · 19643f3 · 19643f3
2 parents 2971068 + af3d5dc
commit 19643f3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/packages/components/src/Select.tsx b/packages/components/src/Select.tsx
@@ -29,6 +29,7 @@ export const Select: ForwardRef<HTMLSelectElement, SelectProps> =
       display: 'block',
       width: '100%',
       p: 2,
+      paddingRight: 4,
       appearance: 'none',
       fontSize: 'inherit',
       lineHeight: 'inherit',

diff --git a/packages/components/test/__snapshots__/index.tsx.snap b/packages/components/test/__snapshots__/index.tsx.snap
@@ -1109,6 +1109,7 @@ exports[`Select renders 1`] = `
   display: block;
   width: 100%;
   padding: 8px;
+  padding-right: 32px;
   -webkit-appearance: none;
   -moz-appearance: none;
   -ms-appearance: none;
@@ -1170,6 +1171,7 @@ exports[`Select renders with custom icon 1`] = `
   display: block;
   width: 100%;
   padding: 8px;
+  padding-right: 32px;
   -webkit-appearance: none;
   -moz-appearance: none;
   -ms-appearance: none;
@@ -1214,6 +1216,7 @@ exports[`Select renders with style props 1`] = `
   display: block;
   width: 100%;
   padding: 8px;
+  padding-right: 32px;
   -webkit-appearance: none;
   -moz-appearance: none;
   -ms-appearance: none;

diff --git a/packages/docs/src/components/presets-demo.js b/packages/docs/src/components/presets-demo.js
@@ -45,7 +45,7 @@ export default function PresetsDemo() {
           <span>Preset:</span>
           <Select
             id="theme"
-            sx={{ display: 'inline-flex', paddingRight: 32 }}
+            sx={{ display: 'inline-flex' }}
             value={theme}
             onChange={(e) => {
               setTheme(e.target.value)