-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update style for core Select component #2058
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/systemui/theme-ui/FtSW8HNYKNN9h9rhPLmrNqDpWQyr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There is just a failing test in the CI, could you please update the snapshot?
packages/components/test/index.js
Okay, I don't have anything against this change, but are we really sure we want to add this I wouldn't classify this as breaking, but it might be annoying for some users. |
Fair enough, it might indeed, especially when using another SVG arrow. (The padding can still be customised from the theme, or?) |
Yeah, I do hesitate a bit with a "magic number", but at the same time, this has basically been a bug with our component if you're not making it full-width through some other means. E.g. with the theme on https://theme.hackclub.com, if I wasn't maximizing the width of the Appreciate this contribution! |
Hi @lachlanjc; DONE : 14c58be |
Hey @lachlanjc @appsparkler, I've added release notes section to the first post. Feel free to tweak it to your liking — it will land in the changelog and GitHub releases. @lachlanjc I've also labeled this with |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit af3d5dc:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hasparus This is ready to merge!
🚀 PR was released in |
Fixing the minor style issue in the core component so that we don't need to fix individual ones.
Release notes
Select
component defaultpaddingRight
style has increased tospaces[4]
(32px by default), to avoid text flowing behind the chevron icon.