Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme editor output in docs #1182

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

mattfwood
Copy link

Currently if you go to the customize / editor page in the docs and edit the theme, the content rendered in the output doesn't update.

I managed to make it work by putting the output editor inside the <EditorProvider /> and then reading the theme value from context.

@hasparus
Copy link
Member

hasparus commented Sep 9, 2020

Hi @mattfwood 👋

Great PR! Thanks!

@hasparus hasparus requested a review from jxnblk September 9, 2020 13:58
@mattfwood
Copy link
Author

Just want to check in on this @hasparus @jxnblk , we could use this fix for allowing our users to create custom themes

@hasparus

This comment has been minimized.

@hasparus hasparus mentioned this pull request Nov 9, 2020
21 tasks
@hasparus hasparus merged commit da77037 into system-ui:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants