Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): Allow styled-system space props on Paragraph #1658

Merged
merged 1 commit into from
Apr 16, 2021
Merged

fix(components): Allow styled-system space props on Paragraph #1658

merged 1 commit into from
Apr 16, 2021

Conversation

vanbujm
Copy link
Contributor

@vanbujm vanbujm commented Apr 16, 2021

References this discussion:

Updated Paragraph component to allow overriding the margin using styled-system space props.

@vercel
Copy link

vercel bot commented Apr 16, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/AVTMH8ywMWpqW4TPSXAzooHfGCff
✅ Preview: https://theme-ui-git-fork-vanbujm-paragraph-style-fix-systemui.vercel.app

@vanbujm vanbujm mentioned this pull request Apr 16, 2021
Merged
@lachlanjc lachlanjc changed the title Paragraph component fix to allow styled-system space props fix(components): Allow styled-system space props on Paragraph Apr 16, 2021
lachlanjc
lachlanjc approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@lachlanjc lachlanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @hasparus

@hasparus hasparus added the enhancement New feature or request label Apr 16, 2021
@hasparus hasparus merged commit 638eabc into system-ui:develop Apr 16, 2021
@hasparus
Copy link
Member

🚀 PR was released in v0.7.1-develop.0 🚀

@hasparus hasparus added the prerelease This change is available in a prerelease. label Apr 19, 2021
@hasparus hasparus mentioned this pull request Apr 19, 2021
Merged
@vanbujm vanbujm deleted the paragraph-style-fix branch April 20, 2021 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachlanjc lachlanjc lachlanjc approved these changes

@atanasster atanasster Awaiting requested review from atanasster

Assignees
No one assigned
Labels
enhancement New feature or request prerelease This change is available in a prerelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vanbujm @hasparus @lachlanjc