Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct location of initialColorModeName: 'light' #1922

Merged
merged 2 commits into from
Sep 8, 2021
Merged

docs: correct location of initialColorModeName: 'light' #1922

merged 2 commits into from
Sep 8, 2021

Conversation

gleich
Copy link
Contributor

@gleich gleich commented Sep 7, 2021

It seems as though initialColorModeName: 'light' should no longer be stored in the root theme object but in the colors object instead. Here I moved it in the documentation to reflect that change.

@vercel
Copy link

vercel bot commented Sep 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/2g6TU98MaEDXXFTLatrhoC8UH2sz
✅ Preview: https://theme-ui-git-fork-gleich-patch-1-systemui.vercel.app

@hasparus
Copy link
Member

hasparus commented Sep 7, 2021

Does this work for you? 👀

I mean... it should work if you put in the theme.config object.

https://theme-ui.com/theming#configuration-flags

If it's inside of colors then it's just color.

Copy link
Member

@hasparus hasparus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If putting it inside .config doesn't work in your app, could you post a bug report with some more details?

@gleich
Copy link
Contributor Author

gleich commented Sep 7, 2021

Ah, I'm sorry. I misread the warning I was getting from eslint. Fixed!

@gleich gleich requested a review from hasparus September 7, 2021 14:04
Copy link
Member

@hasparus hasparus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Copy link
Member

@lachlanjc lachlanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt!!

@lachlanjc lachlanjc merged commit 5854896 into system-ui:develop Sep 8, 2021
@hasparus hasparus added the prerelease This change is available in a prerelease. label Sep 8, 2021
@hasparus
Copy link
Member

hasparus commented Sep 8, 2021

🚀 PR was released in v0.11.2 🚀

@hasparus hasparus added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Sep 8, 2021
@gleich gleich deleted the patch-1 branch September 8, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants