Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export types from @theme-ui/core #670

Merged
merged 1 commit into from Feb 15, 2020
Merged

Export types from @theme-ui/core #670

merged 1 commit into from Feb 15, 2020

Conversation

hasparus
Copy link
Member

Before

Theme can be imported from @theme-ui/core/dist/theme

import { Theme } from '@theme-ui/core/dist/theme'

After

Theme, and all types originally defined in @types/theme-ui can be imported from @theme-ui/core

import { Theme } from '@theme-ui/core'

I listed exported types below:

  • ColorMode
  • SxStyleProp
  • SxProps
  • IntrinsicSxElements
  • Theme

@hasparus hasparus requested a review from mxstbr February 15, 2020 11:54
@LekoArts LekoArts mentioned this pull request Feb 15, 2020
Merged
@hasparus hasparus mentioned this pull request Feb 15, 2020
Merged
mxstbr
mxstbr approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mxstbr mxstbr merged commit 11a3024 into system-ui:master Feb 15, 2020
@hasparus hasparus deleted the export-types branch February 16, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxstbr mxstbr mxstbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hasparus @mxstbr