fix(@theme-ui/custom-properties): TS conversion #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
commented
Feb 15, 2020
|
@mxstbr Good to go 👍 |
LekoArts
commented
Feb 16, 2020
| }, | ||
| "publishConfig": { | ||
| "access": "public" | ||
| }, | ||
| "dependencies": { | ||
| "pluralize": "^8.0.0" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
Should we discuss about dep/devDep/peerDep for those types?
Also see: #672 (comment)
mxstbr
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
This is fine for now, let's merge this and then add a task to move Theme to @theme=ui/css as described in #672 (comment)
Thank you for digging into this, this is awesome! 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts custom-properties over to TS.
.ideawas added to gitignorestrictwas used for tsconfig.jsonPart of #668