WIP: refactor(gatsby-plugin-theme-ui): add typescript #705
Conversation
| "files": [ | ||
| "src/**/*.js", | ||
| "/*.js" | ||
| ], |
There was a problem hiding this comment.
This is a pretty unconventional way to use TS, but I'm not sure if it's worse than copying package.json and README to dist and modifying lerna.json.
| "scripts": { | ||
| "build": "tsc", | ||
| "prepare": "yarn build || true", | ||
| "test": "tsc --noEmit" |
There was a problem hiding this comment.
This could get executed in root package.json (jest && lerna run test)
When a contributor opens the monorepo in his editor, he'll see TypeScript errors on all JSX usages in tests, because the test files may not be included in package tsconfigs (gatsby-plugin-theme-ui). Adding `jsx: react` to the root tsconfig won't hurt.
hasparus
force-pushed
the
ts-gatsby-plugin-theme-ui
branch
from
07cf829
to
9d6d8dd
Compare
| @@ -0,0 +1,365 @@ | |||
| import * as React from 'react' | |||
| @@ -41,7 +41,9 @@ | |||
| "ts-jest": "^25.2.0", | |||
| "typescript": "^3.8.2" | |||
| }, | |||
| "resolutions": {}, | |||
| "resolutions": { | |||
There was a problem hiding this comment.
described in #757 (comment)
| @@ -42,7 +42,8 @@ | |||
| "typescript": "^3.8.2" | |||
| }, | |||
| "resolutions": { | |||
| "@types/vfile-message": "1.0.1" | |||
| "@types/vfile-message": "1.0.1", | |||
| "@types/react": "16.9.23" | |||
There was a problem hiding this comment.
Multiple versions of @types/react in node_modules lead to a lot of suffering (global namespace conflicts).
hasparus
changed the title
|
Marked this as draft now. It needs to be updated. |
|
Ah! Sorry we're doing some updates to the Gatsby plugin -- since this relies on the shadowing API in Gatsby, I'd say let's hold off on converting this plugin and other Gatsby themes in the repo until later, since there are other things to consider. Currently these packages aren't compiled at all and Gatsby consumes them directly... |
Part of #668.
Needs types for
theme-ui.Results of
npm pack:gatsby-plugin-theme-ui-v0.3.0.zip