New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert editor to TypeScript #900

Merged

hasparus merged 70 commits into system-ui:master from dcastil:convert-editor-to-typescript

May 22, 2020

Contributor

dcastil commented May 8, 2020 •

edited

Loading

Partly addresses #668.

This is my first contribution to this project, so I added some TODOs and FIXMEs for things I couldn't help myself for now.

dcastil added 15 commits

May 8, 2020 09:14


          add tsconfig.json

7aa3819


          add tsconfig.json to package.json scripts

9602dc0


          convert entrypoint file

84191dc


          convert EditorProvider

92d2764


          convert Theme

e04280f


          convert Colors

8a8a779


          add TODOs to Colors

ae09d5c


          add missing TODO to Colors

6eee0c8


          convert Styles

23d5643


          convert Theme/Fonts

f580b75


          convert Theme/FontWeights

c0d7d33


          convert FontSizes

95cdbfc


          convert Theme/Space

fbefd2f


          fix missing or incorrectly assigned types

da334cf


          convert Combobox

727e8ea

dcastil commented

View reviewed changes

packages/editor/src/Combobox.tsx Outdated Show resolved Hide resolved

dcastil added 14 commits

May 8, 2020 12:52


          remove unused types in Combobox

dfe0d78


          convert Theme/Lineheights

ae41862


          add more types to ColorPicker

97e13dc


          add more types to Theme/Fonts

4d46a2c


          comment on prop type mismatch in Theme/Colors

98078f5


          add react-color types to Theme/ColorPicker

a8eba4c


          convert Sx/ThemeColorPicker

b8156ee


          convert Sx/Colors

ec1d852


          convert Sx/index

bfc33a9


          convert Sx/Space

5ad1c59


          convert Sx/Margin

da453f0


          convert Sx/Padding

051cb98


          export SpaceProps from Sx/Space

67774e8


          add prop typs to Combobox

b582ea3

Contributor Author

dcastil commented May 18, 2020 •

edited

Loading

@hasparus Is anything missing here which needs to be done before it can get merged?

hasparus reviewed

View reviewed changes

packages/editor/src/ColorPicker.tsx Outdated Show resolved Hide resolved

hasparus reviewed

View reviewed changes

packages/editor/src/ColorPicker.tsx Outdated Show resolved Hide resolved

hasparus reviewed

View reviewed changes

packages/editor/src/Combobox.tsx Outdated Show resolved Hide resolved

hasparus reviewed

View reviewed changes

packages/editor/src/EditorProvider.ts Outdated Show resolved Hide resolved

hasparus reviewed

View reviewed changes

packages/editor/src/Sx/Colors.tsx Outdated Show resolved Hide resolved

hasparus reviewed

View reviewed changes

packages/editor/src/Sx/Margin.tsx Outdated Show resolved Hide resolved

hasparus reviewed

View reviewed changes

packages/editor/src/Sx/Padding.tsx Outdated Show resolved Hide resolved

hasparus reviewed

View reviewed changes

packages/editor/src/Sx/Space.tsx Outdated Show resolved Hide resolved

hasparus reviewed

View reviewed changes

packages/editor/src/Sx/ThemeColorPicker.tsx Outdated Show resolved Hide resolved

hasparus reviewed

View reviewed changes

packages/editor/src/Sx/Typography.tsx Outdated Show resolved Hide resolved

hasparus reviewed

View reviewed changes

packages/editor/src/Theme/Colors.tsx Outdated Show resolved Hide resolved

hasparus reviewed

View reviewed changes

packages/editor/src/Theme/Colors.tsx Outdated Show resolved Hide resolved

hasparus reviewed

View reviewed changes

packages/editor/src/Theme/LineHeights.tsx Outdated Show resolved Hide resolved

hasparus reviewed

View reviewed changes

packages/editor/test/__snapshots__/ColorPicker.tsx.snap Show resolved Hide resolved

Member

hasparus commented May 18, 2020

Hey @dcastil. I left a few comments, mostly nitpicks or Sand/Dust in Netlify's nomenclature.

I'm a bit worried about this gridGap -> gap though.

dcastil added 6 commits

May 19, 2020 20:58


          conver prop types of exported components to interfaces and export them

14451fa


          exclude vscode config from git

efda5f6


          Merge branch 'master' into convert-editor-to-typescript

178845c


          remove typecasting from Field components

698838e


          remove obsolete @ts-ignore

3e03429


          remove generic type from merge function

cfd1541

Contributor Author

dcastil commented May 19, 2020

Hey @hasparus, thanks for the review! I fixed everything but the gap issue. Could you check again?

mostly nitpicks or Sand/Dust in Netlify's nomenclature

Ah cool, I know Netlify's Feedback Ladder!

dcastil and others added 4 commits

May 19, 2020 21:53


          Merge branch 'master' into convert-editor-to-typescript

7be4d85


          add size prop to a test to increase test coverage

f3ebb45


          remove unused props from Label component to reduce code branches

d905339


          Merge branch 'master' into convert-editor-to-typescript

2a85a09

hasparus approved these changes

View reviewed changes

Member

hasparus left a comment

Thanks for the PR @dcastil! Great work!

hasparus merged commit 4ff2eb1 into system-ui:master

dcastil deleted the convert-editor-to-typescript branch

May 22, 2020 20:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet