-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert editor to TypeScript #900
Convert editor to TypeScript #900
Conversation
@hasparus Is anything missing here which needs to be done before it can get merged? |
Hey @dcastil. I left a few comments, mostly nitpicks or Sand/Dust in Netlify's nomenclature. I'm a bit worried about this |
Hey @hasparus, thanks for the review! I fixed everything but the
Ah cool, I know Netlify's Feedback Ladder! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @dcastil! Great work!
Partly addresses #668.
This is my first contribution to this project, so I added some TODOs and FIXMEs for things I couldn't help myself for now.