Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core timestamp to string to match other date fields #60

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

btkostner
Copy link
Contributor

Updates the core bottle timestamp to a string for ISO datetime like all the other datetime fields we have.

This will need a change to the elixir branch as well.

@btkostner btkostner requested a review from a team as a code owner April 23, 2021 16:57
@doomspork
Copy link
Contributor

Let's hold off on this as it doesn't really add value but does case a pretty good breaking change.

The original justification for the ISO was that the database stores DateTime, not timestamps, so we do a bunch of conversion. The message envelope doesn't need to be human readable and using timestamps makes certain things at that level of the process simpler.

@macifell macifell marked this pull request as draft January 27, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants