Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore key presses that trigger ghost keys #40

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Ignore key presses that trigger ghost keys #40

merged 2 commits into from
Mar 31, 2020

Conversation

crawfxrd
Copy link
Member

If a key press is detected that would trigger a ghost key, ignore the key.

Based on QMK implementation (keyboard.c).

Resolves: #24

jackpot51
jackpot51 approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@jackpot51 jackpot51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works on the lemp9, what else do you want to do?

@crawfxrd crawfxrd marked this pull request as ready for review March 31, 2020 22:24
@crawfxrd
Copy link
Member Author

I was testing it and forgot to unmark it WIP.

@jackpot51 jackpot51 merged commit d2ae447 into master Mar 31, 2020
@jackpot51 jackpot51 deleted the wip/ghost branch March 31, 2020 22:29
@ben-dyer ben-dyer mentioned this pull request Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpot51 jackpot51 jackpot51 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent ghost keys
2 participants
@crawfxrd @jackpot51