-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bios: Replace model check with manufacturer check #97
Conversation
Instead of checking the model string against every system released with coreboot, just check that the manufacturer is System76. Signed-off-by: Tim Crawford <tcrawford@system76.com>
Where does that manufacturer string come from? Because our desktops set multiple manufacturer strings in DMI to
|
Type 1 SMBIOS data, as set by coreboot.
The BIOS vendor check is still there. This change only affects coreboot models. |
So it'll probably match on all the Thelios then. I'll give it a test and see what happens. |
Thelio-r3 seems ok. The MSI/AMI update thing started normally and the firmware installed without issue. I would like to test an Asus, ASRock, and Gigabyte board as well, since they all update slightly differently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues on major-r4, mira-b4.1, spark-b1, or thelio-r2. If it does pick these systems up in the match, it doesn't look like there are any side effects.
Instead of checking the model string against every system released with coreboot, just check that the manufacturer is System76.
Test: Flash a firmware-open board with this checked out.