Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/buyer approve request #53

Merged

Conversation

hotay
Copy link
Contributor

@hotay hotay commented Jul 12, 2016

hotay and others added 30 commits June 18, 2016 15:49
setup frontend test coverage and remove old test
upgrade axios post user create form as xxx-form-url-endcode content-type
fix field `name` and `cr_account` not include in transaction_item, fi…
module.exports = function (httpServer) {
var io = require('socket.io')(httpServer);

io.of('/notify').on('connection', function (socket) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I normally keep a reference to the namespace when creating one as the namespace object has plenty of useful methods (especially server-side) when managing multiple clients.

const nsp = io.of('/notify');
nsp.on('connection', function (socket) {

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.04%) to 93.958% when pulling 7d274bd on hotay:feature/buyer-approve-request into cafd38d on systemaccounting:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.3%) to 91.718% when pulling a1932c2 on hotay:feature/buyer-approve-request into cafd38d on systemaccounting:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.3%) to 91.691% when pulling cef9ab7 on hotay:feature/buyer-approve-request into cafd38d on systemaccounting:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-8.3%) to 91.691% when pulling cef9ab7 on hotay:feature/buyer-approve-request into cafd38d on systemaccounting:master.

@hotay
Copy link
Contributor Author

hotay commented Jul 23, 2016

@mxfactorial this PR resolves #46, #11,
#9

  • Please do some testing, I will write more test to cover 100% again.

_Note_

  • For now, you can request a transaction the username match with cr_author of the transaction will receive a notification.
  • Transact and reject button within transactionRequestDetail screen aren't functional yet because missing endpoint.
  • Clear all will update the receive_time instead of removing corresponding notification in the database

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 336200c on hotay:feature/buyer-approve-request into cafd38d on systemaccounting:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d9e6ac3 on hotay:feature/buyer-approve-request into cafd38d on systemaccounting:master.

@hotay
Copy link
Contributor Author

hotay commented Jul 24, 2016

@mxfactorial ready for testing.

_Note_:
When create a transaction add create_by field which is auto populated by current login user. This field will help we identify a transaction is bid or ask type.

@mxfactorial
Copy link
Contributor

Thank you, but this information is already supplied by examining whether db_time OR cr_time are present (if BOTH, then record = transaction). Please remove.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 85e44da on hotay:feature/buyer-approve-request into cafd38d on systemaccounting:master.

@coveralls
Copy link

coveralls commented Jul 25, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 03bd39e on hotay:feature/buyer-approve-request into cafd38d on systemaccounting:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3a9d73d on hotay:feature/buyer-approve-request into cafd38d on systemaccounting:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d0108c8 on hotay:feature/buyer-approve-request into cafd38d on systemaccounting:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants