Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtraTrees= via InitrdInclude= incorrectly resolved #2579

Closed
septatrix opened this issue Apr 2, 2024 · 2 comments · Fixed by #2583
Closed

ExtraTrees= via InitrdInclude= incorrectly resolved #2579

septatrix opened this issue Apr 2, 2024 · 2 comments · Fixed by #2583
Labels

Comments

@septatrix
Copy link
Contributor

When using ExtraTrees= fom a file which is included via InitrdInclude= which itself was set in the config file of an image the paths are incorrectly resolved. More specifically they seem to be resolved relative to the project root instead of the config file (or the image root).

I would have expected that paths are resolved relative to the included config file. This is also the case when including a directory which contains a mkosi.conf file.

I have not yet had the time to check if this also happens with a normal include, without the image step, or with attributes which resolve paths.

@DaanDeMeyer
Copy link
Contributor

This is expected behavior, we only change directory when parsing a directory containing a mkosi.conf file. If we're parsing a regular file, we do not change directory.

DaanDeMeyer added a commit to DaanDeMeyer/mkosi that referenced this issue Apr 3, 2024
@DaanDeMeyer
Copy link
Contributor

#2583 should give you a way to specify that you wants paths to be interpreted relative to the parent directory of the config file.

@DaanDeMeyer DaanDeMeyer added the RFE label Apr 3, 2024
DaanDeMeyer added a commit to DaanDeMeyer/mkosi that referenced this issue Apr 3, 2024
DaanDeMeyer added a commit to DaanDeMeyer/mkosi that referenced this issue Apr 3, 2024
DaanDeMeyer added a commit that referenced this issue Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants