mkosi: create builddir if configured but missing #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a builddir is explicitly configured but missing, automatically create it. This follows the logic already implemented for mkosi.output/ and mkosi.cache/. This is particularly useful when storing mkosi settings in a git repo, as git normally doesn't allow us to store empty directories, and hence we cannot make use of auto-discovery of mkosi.output/ and mkosi.cache/. By configuring these paths explicitly in mkosi.default however, we can work around this, as in that case we'll create the directories if needed.
poettering
added a commit
to poettering/systemd
that referenced
this pull request
Oct 26, 2017
This way these dirs will be created automatically if they are missing, thus always guaranteeing optimal speedy behaviour. (Well at least, after systemd/mkosi#181 is merged)
poettering
added a commit
to poettering/systemd
that referenced
this pull request
Nov 9, 2017
This way these dirs will be created automatically if they are missing, thus always guaranteeing optimal speedy behaviour. (Well at least, after systemd/mkosi#181 is merged)
poettering
added a commit
to poettering/systemd
that referenced
this pull request
Nov 10, 2017
This way these dirs will be created automatically if they are missing, thus always guaranteeing optimal speedy behaviour. (Well at least, after systemd/mkosi#181 is merged)
poettering
added a commit
to poettering/systemd
that referenced
this pull request
Nov 10, 2017
This way these dirs will be created automatically if they are missing, thus always guaranteeing optimal speedy behaviour. (Well at least, after systemd/mkosi#181 is merged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a builddir is explicitly configured but missing, automatically create
it.
This follows the logic already implemented for mkosi.output/ and
mkosi.cache/.
This is particularly useful when storing mkosi settings in a git repo,
as git normally doesn't allow us to store empty directories, and hence
we cannot make use of auto-discovery of mkosi.output/ and mkosi.cache/.
By configuring these paths explicitly in mkosi.default however, we can
work around this, as in that case we'll create the directories if
needed.