Support direct kernel booting a disk image #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanDeMeyer
changed the title
DaanDeMeyer
force-pushed
the
disk-direct-boot
branch
from
2c8b787
to
c0ef822
Compare
keszybz
reviewed
Sep 7, 2023
mkosi/qemu.py
Outdated
| # kernel argument instead. | ||
| root = finalize_root(find_partitions(fname)) | ||
| if not root: | ||
| die("Cannot direct boot image without root or usr partition") |
There was a problem hiding this comment.
I think direct is more useful here, since we're using the direct kernel boot feature, but I'll change it to "Cannot direct kernel boot image ..."
There was a problem hiding this comment.
That grammatical error is grating. "Cannot perform a direct kernel boot", or "Direct kernel boot is not possible", etc.
This requires two things: 1. We need to generate a split initrd again to pass to -initrd 2. We need to synthesize a root= argument as we can't rely on gpt-auto-generator since we're not using EFI. We move the partition and root= specific stuff to a new file partition.py so we can access it from qemu.py as well. We also introduce extract_pe_section() since we now use the logic twice.
DaanDeMeyer
force-pushed
the
disk-direct-boot
branch
from
c0ef822
to
8f26a6d
Compare
behrmann
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires two things:
gpt-auto-generator since we're not using EFI.
We move the partition and root= specific stuff to a new file
partition.py so we can access it from qemu.py as well.
We also introduce extract_pe_section() since we now use the logic
twice.