Don't pass down empty lists to subimages unless explicitly configured #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to check whether a value was explicitly configured in configuration files or on the CLI.
This allows us to use context.config to determine whether a value was specified in a configuration file or not.
This gives us more flexibility in configuring the individual subimages.
DaanDeMeyer
force-pushed
the
fix
branch
2 times, most recently
from
dd8f3f9
to
56b56b7
Compare
behrmann
reviewed
Aug 6, 2024
This makes sure that subimages use default values for list based settings unless they were explicitly configured in configuration or on the command line or have a non-empty default value in the main image. Fixes systemd#2874
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that subimages use default values for list based
settings unless they were explicitly configured in configuration or
on the command line or have a non-empty default value in the main
image.
Fixes #2874