Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vagrant: try to run the networkd test suite in parallel w/ the rest #492

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

mrc0mmand
Copy link
Member

No description provided.

@yuwata
Copy link
Member

yuwata commented May 30, 2022

Looks nice. Thank you! I guess this massively improve the performance.

@mrc0mmand
Copy link
Member Author

Looks nice. Thank you! I guess this massively improve the performance.

So far it looks promising, the run time of the Arch job went down by 30 minutes (to approx. 1.5 hours). I just want to test this further if it doesn't make the tests more flaky.

@mrc0mmand mrc0mmand force-pushed the experiments branch 2 times, most recently from 804ac31 to 1d3f3e3 Compare May 31, 2022 12:13
@mrc0mmand
Copy link
Member Author

So, this seems to be working as expected, at least in the Arch runs. The only exception are the *.dusty.ci.centos.org nodes, where we already disable any kind of parallelism, since the machines are much slower and parallelism leads to very flaky tests (even in this case the networkd test suite failed in one tests just on the first try). So once in a while the CI job will still take the full ~2 hours, but I still think this change makes sense, since on 4 out of 5 chassis we'll save ~30 minutes per job.

I'll test the C8S part now with the same change, but it should, hopefully, behave the same as in the Arch case.

@mrc0mmand mrc0mmand marked this pull request as ready for review June 1, 2022 10:47
@mrc0mmand mrc0mmand merged commit bedc1b9 into systemd:master Jun 1, 2022
@mrc0mmand mrc0mmand deleted the experiments branch June 1, 2022 10:47
@yuwata
Copy link
Member

yuwata commented Jun 1, 2022

Thank you!!

yuwata added a commit to yuwata/systemd that referenced this pull request Jun 10, 2022
After systemd/systemd-centos-ci#492 is merged,
the networkd test may be running when test-sd-device is invoked.
Let's exclude net subsystem.
yuwata added a commit to yuwata/systemd that referenced this pull request Jun 10, 2022
After systemd/systemd-centos-ci#492 is merged,
the networkd test may be running when test-sd-device is invoked.
Let's exclude net subsystem.
mrc0mmand pushed a commit to mrc0mmand/rhel-9 that referenced this pull request Jun 22, 2022
After systemd/systemd-centos-ci#492 is merged,
the networkd test may be running when test-sd-device is invoked.
Let's exclude net subsystem.

(cherry picked from commit 3284dd9)

Related: #2087652
mrc0mmand pushed a commit to mrc0mmand/rhel-9 that referenced this pull request Jun 22, 2022
After systemd/systemd-centos-ci#492 is merged,
the networkd test may be running when test-sd-device is invoked.
Let's exclude net subsystem.

(cherry picked from commit 3284dd9)

Related: #2087652
mrc0mmand pushed a commit to mrc0mmand/rhel-9 that referenced this pull request Jun 22, 2022
After systemd/systemd-centos-ci#492 is merged,
the networkd test may be running when test-sd-device is invoked.
Let's exclude net subsystem.

(cherry picked from commit 3284dd9)

Related: #2087652
mrc0mmand pushed a commit to mrc0mmand/rhel-9 that referenced this pull request Jun 22, 2022
After systemd/systemd-centos-ci#492 is merged,
the networkd test may be running when test-sd-device is invoked.
Let's exclude net subsystem.

(cherry picked from commit 3284dd9)

Related: #2087652
Yamakuzure pushed a commit to elogind/elogind that referenced this pull request Dec 23, 2022
After systemd/systemd-centos-ci#492 is merged,
the networkd test may be running when test-sd-device is invoked.
Let's exclude net subsystem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants