Skip to content

Commit

Permalink
resolved: minor cleanups
Browse files Browse the repository at this point in the history
(cherry picked from commit c805014)
  • Loading branch information
keszybz committed Feb 2, 2021
1 parent fd76ba6 commit 91ba2ea
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 12 deletions.
7 changes: 3 additions & 4 deletions src/resolve/resolved-dns-query.c
Expand Up @@ -50,7 +50,6 @@ static void dns_query_candidate_stop(DnsQueryCandidate *c) {
}

DnsQueryCandidate* dns_query_candidate_free(DnsQueryCandidate *c) {

if (!c)
return NULL;

Expand All @@ -69,7 +68,7 @@ DnsQueryCandidate* dns_query_candidate_free(DnsQueryCandidate *c) {
}

static int dns_query_candidate_next_search_domain(DnsQueryCandidate *c) {
DnsSearchDomain *next = NULL;
DnsSearchDomain *next;

assert(c);

Expand Down Expand Up @@ -602,8 +601,8 @@ static int dns_query_try_etc_hosts(DnsQuery *q) {

assert(q);

/* Looks in /etc/hosts for matching entries. Note that this is done *before* the normal lookup is done. The
* data from /etc/hosts hence takes precedence over the network. */
/* Looks in /etc/hosts for matching entries. Note that this is done *before* the normal lookup is
* done. The data from /etc/hosts hence takes precedence over the network. */

r = manager_etc_hosts_lookup(
q->manager,
Expand Down
16 changes: 8 additions & 8 deletions src/resolve/resolved-dns-query.h
Expand Up @@ -31,19 +31,19 @@ struct DnsQueryCandidate {
struct DnsQuery {
Manager *manager;

/* When resolving a service, we first create a TXT+SRV query,
* and then for the hostnames we discover auxiliary A+AAAA
* queries. This pointer always points from the auxiliary
* queries back to the TXT+SRV query. */
/* When resolving a service, we first create a TXT+SRV query, and then for the hostnames we discover
* auxiliary A+AAAA queries. This pointer always points from the auxiliary queries back to the
* TXT+SRV query. */
DnsQuery *auxiliary_for;
LIST_HEAD(DnsQuery, auxiliary_queries);
unsigned n_auxiliary_queries;
int auxiliary_result;

/* The question, formatted in IDNA for use on classic DNS, and as UTF8 for use in LLMNR or mDNS. Note that even
* on classic DNS some labels might use UTF8 encoding. Specifically, DNS-SD service names (in contrast to their
* domain suffixes) use UTF-8 encoding even on DNS. Thus, the difference between these two fields is mostly
* relevant only for explicit *hostname* lookups as well as the domain suffixes of service lookups. */
/* The question, formatted in IDNA for use on classic DNS, and as UTF8 for use in LLMNR or mDNS. Note
* that even on classic DNS some labels might use UTF8 encoding. Specifically, DNS-SD service names
* (in contrast to their domain suffixes) use UTF-8 encoding even on DNS. Thus, the difference
* between these two fields is mostly relevant only for explicit *hostname* lookups as well as the
* domain suffixes of service lookups. */
DnsQuestion *question_idna;
DnsQuestion *question_utf8;

Expand Down

0 comments on commit 91ba2ea

Please sign in to comment.