[v247] backport routing policy rule fix #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As routing policy rules are managed by Manager. [#17960,1/4] cherry-picked from 18f2ee3
[#17960,2/4] cherry-picked from 40424f1
[#17960,3/4] cherry-picked from ea81208
[#17960,4/4] cherry-picked from c18c53c
[#17477,1/5] cherry-picked from 1e5fd32
…ot support FRA_PROTOCOL Otherwise, each configured rule is treated as foreign. [#17477,2/5] cherry-picked from 569eeb0
[#17477,3/5] cherry-picked from e737dce
networkd already drop foreign address, routes, and nexthops on startup, except those created by kernel. However, previously, routing policy rules were not. The logic of serialization/deserialization of rules only works for rules created by previous invocation of networkd, and does not work for one created by other tools like `ip rule`. This makes networkd drop foreign routing policy rules except created by kernel on startup. Also, remove rules created by networkd when the corresponding links are dropped or networkd is stopping. [#17477,4/5] cherry-picked from 0b81225
We already handle foreign routing policy rules correctly by the previous commit. So, the serialization/deserialization of rules are not necessary anymore. [#17477,5/5] cherry-picked from a9d240f
[#18109,1/7] cherry-picked from 3141c81
By the previous commit, the checks are not necessary any more. [#18109,3/7] cherry-picked from 57fe5a4
routing_policy_rule_get() in link_set_routing_policy_rules() does not work when [RoutingPolicyRule] section does not have From= or To=. [#18109,4/7] cherry-picked from c1934a8
[#18109,5/7] cherry-picked from 49de8d5
[#18109,6/7] cherry-picked from a75466e
…reload or reconfigure [#18109,7/7] cherry-picked from 49ff3f3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports systemd/systemd#17960, systemd/systemd#17477 and systemd/systemd#18109.
For people relying on policy routing, losing network connections after
networkctl reloadis a disaster. This issue affects the upcoming Ubuntu 21.04 (hirsute), Debian 11 (bullseye) and Debian 10 (buster-backports). Hope get this merged into v247-stable ASAP.Fixes systemd/systemd#18107
Close #93