core: new feature MountImages #16321
Conversation
This comment has been minimized.
This comment has been minimized.
Done, let me know if it looks like what you had in mind or there's some more improvements to make. Thanks! |
|
Where's the log for the sephamoreci? I'm clicking around on the webpage interface but can't see it |
|
centos failure looks unrelated, it's in the udev selftest:
|
Yep, that's #15978... |
|
Can anybody kick semaphoreci? There seems to be no logs available, as far as I can see |
I've already sent an email to the Semaphore CI support, it's been happening for the past few days pretty constantly. Just ignore it for now. |
|
FWIW I switched back to Ubuntu Trusty there and to judge from https://semaphoreci.com/systemd/systemd/branches/pull-request-16321/builds/4 it seems to be working in the sense that the logs are there at least. Probably the new platform is still kind of experimental. |
|
I've just switched to Ubuntu Xenial and judging by https://semaphoreci.com/systemd/systemd/branches/pull-request-16321/builds/5 the tests are going to pass so let's stick to it for now. @mrc0mmand could you switch it to Ubuntu Bionic once they reply to you? |
Will do, thanks for looking into that! |
|
I think it's already too late give rc1 is out, but just in case: even if approved, I think this should be delayed until after v246 is out, as I'd like #16308 to be sorted one way or the other before this option makes its way into a release, so the same interface can be used for this option. |
|
@evverx the Semaphore CI team got back to me:
so I switched the Sempahore CI to Ubuntu Bionic to see how it fares. |
poettering
added
the
reviewed/needs-rework 🔨
This comment has been minimized.
This comment has been minimized.
There's a broken-deps pandemic, so just ignore it for now - #16453 (comment) |
bluca
force-pushed
the
mount_images
branch
2 times, most recently
from
3b6d5a1
to
e151f0c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
New push fixes the UNIT_WRITE_FLAGS_NOOP to make the runtime change not happen as well (previously it erroneously just wrapped the unit setting write, not the global data structure update) |
keszybz
removed
the
reviewed/needs-rework 🔨
bluca
force-pushed
the
mount_images
branch
2 times, most recently
from
f6ce7b6
to
921318b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Covers some functionality that we want to use for config tuples
This allows separators to be escaped, for example to allow "a\:b:c", to be treated as "a:b", "c" with ":" as the separator.
Given a string in the format 'one:two three four:five', returns a string vector with each word. If the second element of the tuple is not present, an empty string is returned in its place, so that the vector can be processed in pairs. [zjs: use EXTRACT_UNESCAPE_SEPARATORS instead of EXTRACT_CUNESCAPE_RELAX. This way we do escaping exactly once and in normal strict mode.]
Follows the same pattern and features as RootImage, but allows an arbitrary mount point under / to be specified by the user, and multiple values - like BindPaths. Original implementation by @topimiettinen at: systemd#14451 Reworked to use dissect's logic instead of bare libmount() calls and other review comments. Thanks Topi for the initial work to come up with and implement this useful feature.
|
LGTM. |
Picking up from #14451 as discussed there, and applying the review suggestions:
(note that normally I'd do a single commit for something like this, but wanted to keep the original commit from #14451 to give full credit to @topimiettinen in the git history)