network: fix IPv6 address removal issue #20081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also slightly rename functions.
Previously, the router address was appended to each configuration. But that is inefficient in both speed and memory usage. This makes each configuration such as address, route, dnssl, and rdnss provided by the same router is managed by `struct NDiscInfo`, which also contains the router address. Each NDiscInfo is managed by the router address, so we can easily search configurations provided by a router.
Previously, NDisc configurations with `marked` flag are considered as old, and removed when all netlink messages are processed and at least one address becomes ready. However, when request queue was introduced, the logic was not updated. As all requests are once queued and processed later when each request is ready, the `marked` flag of each configuration is not removed within the same event. Thus, all previous configurations are removed before no address or route request is processed. This causes the issue systemd#20050. This introduces another request type to clear old NDisc configureations to make the cleanup is certainly processed after all address and route requests are processed. Fixes systemd#20050.
|
This pull request introduces 1 alert when merging f40ed45 into 24c006d - view on LGTM.com new alerts:
|
|
Let's postpone this, as the change is too big to be included v249. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20050.