-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump stefanbuck/github-issue-parser from 2.0.4 to 3.0.1 #25900
build(deps): bump stefanbuck/github-issue-parser from 2.0.4 to 3.0.1 #25900
Conversation
6f16dbb
to
1c167e5
Compare
Bumps [stefanbuck/github-issue-parser](https://github.com/stefanbuck/github-issue-parser) from 2.0.4 to 3.0.1. - [Release notes](https://github.com/stefanbuck/github-issue-parser/releases) - [Commits](stefanbuck/github-issue-parser@f80b14f...c1a559d) --- updated-dependencies: - dependency-name: stefanbuck/github-issue-parser dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
1c167e5
to
a4b9bda
Compare
I happened to go over the Dependabot logs and found this weird error message: updater | 2024/03/31 21:22:13 ERROR <job_807574419> Error processing stefanbuck/github-issue-parser (Dependabot::SharedHelpers::HelperSubprocessFailed)
updater | 2024/03/31 21:22:13 ERROR <job_807574419> error: no such commit c1a559d78bfb8dd05216dab9ffd2b91082ff5324 That commit doesn't exist in the repository so apparently the action pulls stefanbuck/github-issue-parser@c1a559d and that doesn't look right :-) |
To judge from stefanbuck/github-issue-parser#70 (comment) (It's kind of concerning that Dependabot happily opens PRs pointing actions to commits like that and then keeps using them) |
They should probably rename Dependabot to SCAaaS (Supply chain attack as a Service) ;) But jokes aside, this behavior is indeed concerning. |
This sort of thing (without Dependabot involved) was reported in https://www.chainguard.dev/unchained/what-the-fork-imposter-commits-in-github-actions-and-ci-cd and in response GitHub fixed the documentation :-) Anyway it seems it should be fine to point the action to stefanbuck/github-issue-parser@1e5bdee and wait for it to be fully compatible with SHAs. I think that action comes with |
The SHA for this action was updated by Dependabot in systemd#25900 to a commit which later disappeared from the repo. Since then Dependabot kept (silently) failing to bump the SHA further: updater | 2024/03/31 21:22:13 ERROR <job_807574419> Error processing stefanbuck/github-issue-parser (Dependabot::SharedHelpers::HelperSubprocessFailed) updater | 2024/03/31 21:22:13 ERROR <job_807574419> error: no such commit c1a559d78bfb8dd05216dab9ffd2b91082ff5324 See: systemd#25900 (comment) Let's bump the SHA manually to v3.1.0 to get Dependabot back on the track. Co-authored-by: Evgeny Vereshchagin <evvers@ya.ru>
I bumped the SHA to v3.1.0 in #32050. It would be great if this could be caught somewhat automagically (like you've already proposed in ossf/scorecard#2733). |
Ideally it should be possible to turn off that "feature" but it isn't going to happen. As far as I can remember it wasn't doable because of the GitHub API rate limits. The Google folks were planning to integrate it into their cron job (which doesn't help to prevent that sort of thing in the first place) but since that cron job is responsible for scanning a lot of projects it was most likely to be banned too so it all kind of stalled. It's just so deeply ingrained in GitHub so it seems it's neither fixable nor easily detectable when it happens. |
The SHA for this action was updated by Dependabot in #25900 to a commit which later disappeared from the repo. Since then Dependabot kept (silently) failing to bump the SHA further: updater | 2024/03/31 21:22:13 ERROR <job_807574419> Error processing stefanbuck/github-issue-parser (Dependabot::SharedHelpers::HelperSubprocessFailed) updater | 2024/03/31 21:22:13 ERROR <job_807574419> error: no such commit c1a559d78bfb8dd05216dab9ffd2b91082ff5324 See: #25900 (comment) Let's bump the SHA manually to v3.1.0 to get Dependabot back on the track. Co-authored-by: Evgeny Vereshchagin <evvers@ya.ru>
Bumps stefanbuck/github-issue-parser from 2.0.4 to 3.0.1.
Release notes
Sourced from stefanbuck/github-issue-parser's releases.
... (truncated)
Commits
c1a559d
build741688b
feat: add issue-body default (#47)de423fc
docs: Add migration section0b27d4a
feat: mitigating script injection attacks by passing issue body as env var (#42)1d341cb
feat: parse checkboxes (#21)284e5eb
fix(deps): bump@actions/core
from 1.9.1 to 1.10.09a9657d
build(deps-dev): bump jest from 29.0.1 to 29.1.2f87cd98
Add snyk and version badge4e72cf0
doc: Add exampleadvanced-issue-labeler
(#40)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)