test: Rework TEST-02-UNITTESTS #32394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
please-review
bluca
approved these changes
Apr 22, 2024
bluca
added
good-to-merge/waiting-for-ci 👍
DaanDeMeyer
force-pushed
the
testsuite-02-rework
branch
from
19b4b48
to
f804cf7
Compare
mrc0mmand
reviewed
Apr 22, 2024
github-actions
bot
added
please-review
DaanDeMeyer
force-pushed
the
testsuite-02-rework
branch
from
f804cf7
to
8e16310
Compare
bluca
added
good-to-merge/waiting-for-ci 👍
Currently, A large amount of unit test output is logged directly to the console instead of to the per test log file as any subprocesses executed by a test manager will detect that stderr is not connected to the journal and log directly to /dev/console instead. To solve this issue, let's make sure all tests are connected directly to the journal by running them with systemd-run. We also simplify the entire test script by getting rid of the custom queue and replicating it with xargs instead. By using bash's function export feature, we can make our run_test() function available to the bash subprocess spawned by xargs. Once a test is finished, we read its logs from the journal and put them in the appropriate file if needed.
DaanDeMeyer
force-pushed
the
testsuite-02-rework
branch
from
8e16310
to
534bf2a
Compare
github-actions
bot
added
please-review
DaanDeMeyer
added
good-to-merge/waiting-for-ci 👍
|
TEST-02-UNITTESTS passed on the CentOS CI workflows, so merging |
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, A large amount of unit test output is logged directly to the console instead of to the per test log file as any subprocesses executed by a test manager will detect that stderr is not connected to the journal and log directly to /dev/console instead.
Let's make sure all unit test output is logged to the journal by running each test as a service with systemd-run. We also simplify the entire test script by getting rid of the custom queue and replicating it with xargs instead. By using bash's function export feature, we can make our run_test() function available to the bash subprocess spawned by xargs.
Once a test is finished, we read its logs from the journal and put them in the appropriate file if needed.