Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-journal-flush occasionally fails in TEST-02-UNITTESTS #32436

Closed
mrc0mmand opened this issue Apr 23, 2024 · 7 comments
Closed

test-journal-flush occasionally fails in TEST-02-UNITTESTS #32436

mrc0mmand opened this issue Apr 23, 2024 · 7 comments
Labels
bug 🐛 Programming errors, that need preferential fixing journal tests
Milestone
v256

Comments

@mrc0mmand
Copy link
Member

mrc0mmand commented Apr 23, 2024 •
edited
Loading 

=== Failed test log ===
--- test-journal-flush begin ---
[   19.359951] systemd[1]: Started test-journal-flush.service.
[   19.363554] systemd-executor[4348]: SELinux enabled state cached to: disabled
[   19.364808] (al-flush)[4348]: Found cgroup2 on /sys/fs/cgroup/, full unified hierarchy
[   19.364895] (al-flush)[4348]: Found cgroup2 on /sys/fs/cgroup/, full unified hierarchy
[   19.376752] test-journal-flush[4348]: /* test_journal_flush_compact */
[   19.572253] test-journal-flush[4348]: Assertion 'o->object.type == OBJECT_ENTRY_ARRAY' failed at src/libsystemd/sd-journal/journal-file.c:2724, function bump_entry_array(). Aborting.
[   20.048982] systemd[1]: test-journal-flush.service: Main process exited, code=dumped, status=6/ABRT
[   20.049230] systemd[1]: test-journal-flush.service: Failed with result 'core-dump'.
--- test-journal-flush end ---

Seen in:
@mrc0mmand mrc0mmand mentioned this issue Apr 23, 2024
Merged
@DaanDeMeyer
Copy link
Contributor

I'm assuming this is because the journal gets seriously put to the test in UNIT-02-UNITTESTS now with #32394 .

@DaanDeMeyer
Copy link
Contributor

@yuwata Any clue on this one? I don't see how this assertion could be triggered from generic_array_get()

@yuwata yuwata added the bug 🐛 Programming errors, that need preferential fixing label Apr 24, 2024
@yuwata yuwata added this to the v256 milestone Apr 24, 2024
@yuwata
Copy link
Member

yuwata commented Apr 30, 2024

@mrc0mmand Why there is no coredump for the failure??

@yuwata
Copy link
Member

yuwata commented Apr 30, 2024

Maybe, this is triggered when the journal is rotating during the test-journal-flush is running??

yuwata added a commit to yuwata/systemd that referenced this issue Apr 30, 2024
@yuwata
test-journal-flush: use archived journal if possible
2c3344c 
Workaround for systemd#32436.

The test may fail if the journal is vacuumed or rotated during the test is running.
Let's use the newest archive file for safety.
@yuwata yuwata mentioned this issue Apr 30, 2024
Merged
@yuwata
Copy link
Member

yuwata commented Apr 30, 2024

-> #32571

DaanDeMeyer pushed a commit that referenced this issue Apr 30, 2024
@yuwata @DaanDeMeyer
test-journal-flush: use archived journal if possible
8719a65 
Workaround for #32436.

The test may fail if the journal is vacuumed or rotated during the test is running.
Let's use the newest archive file for safety.
@mrc0mmand
Copy link
Member Author

Resolved by #32571.

@mrc0mmand
Copy link
Member Author

@mrc0mmand Why there is no coredump for the failure??

test-execute unfortunately produces a couple of intentional coredumps, so any coredump from that test is ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Programming errors, that need preferential fixing journal tests
Milestone
v256
Development

No branches or pull requests
4 participants
@mrc0mmand @DaanDeMeyer @yuwata @YHNdnzj