test-journal-flush: use archived journal if possible #32571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for systemd#32436. The test may fail if the journal is vacuumed or rotated during the test is running. Let's use the newest archive file for safety.
github-actions
bot
added
journal
please-review
|
Important An -rc1 tag has been created and a release is being prepared, so please note that PRs introducing new features and APIs will be held back until the new version has been released. |
DaanDeMeyer
reviewed
Apr 30, 2024
| if (r < 0) | ||
| return r; | ||
|
|
||
| p = strjoina("/var/log/journal/", SD_ID128_TO_STRING(machine_id), "/"); |
There was a problem hiding this comment.
Hmm this assumes we have a persistent journal. I'm considering making mkosi CI tests use only a runtime journal and not a persistent one, but this test would break then.
There was a problem hiding this comment.
If there is no persistent journal, the test falls back to use runtime journal.
DaanDeMeyer
approved these changes
Apr 30, 2024
github-actions
bot
removed
the
please-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #32436.
The test may fail if the journal is vacuumed or rotated during the test is running. Let's use the newest archive file for safety.