Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkd: DHCP client - ignore default route if classless static rout… #6885

Merged
merged 1 commit into from Nov 22, 2017

Conversation

ssahani
Copy link
Contributor

@ssahani ssahani commented Sep 21, 2017

…e is set.

According to RFC 3442:

If the DHCP server returns both a Classless Static Routes option and
a Router option, the DHCP client MUST ignore the Router option.

This work fixes #5695.

@yuwata yuwata added the network label Oct 11, 2017
@poettering
Copy link
Member

looks OK, but needs rebase.

…s set

According to RFC 3442:

If the DHCP server returns both a Classless Static Routes option and
a Router option, the DHCP client MUST ignore the Router option.

fixes systemd#5695.
@yuwata yuwata added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed needs-rebase labels Nov 21, 2017
@keszybz keszybz removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Nov 22, 2017
@keszybz keszybz merged commit 5f04a20 into systemd:master Nov 22, 2017
@ssahani ssahani deleted the issue-5695 branch November 22, 2017 08:40
@asavah
Copy link
Contributor

asavah commented Nov 23, 2017

This crap kills default route v4 altogether.
Was this even runtime tested?

Capture dhcp reply from the router:


          Your-IP 192.168.X.179
          Server-IP 192.168.X.1
          Client-Ethernet-Address X
          Vendor-rfc1048 Extensions
            Magic Cookie 0x63825363
            DHCP-Message Option 53, length 1: ACK
            Server-ID Option 54, length 4: 192.168.X.1
            Lease-Time Option 51, length 4: 86400
            RN Option 58, length 4: 43200
            RB Option 59, length 4: 75600
            Subnet-Mask Option 1, length 4: 255.255.255.0
            BR Option 28, length 4: 192.168.X.255
            Hostname Option 12, length 4: "rpi3"
            Domain-Name Option 15, length 8: "X.Y"
            Domain-Name-Server Option 6, length 8: 192.168.X.1,192.168.X.5
            Default-Gateway Option 3, length 4: 192.168.X.1

DHCP server is dnsmasq.

No classless static routes, only gw.
On the client:

ip ro sh
192.168.X.0/24 dev eth0 proto kernel scope link src 192.168.X.179

@ssahani
Copy link
Contributor Author

ssahani commented Nov 23, 2017

yikes messed up in the rebase. Please try with ssahani@13c30fa

keszybz added a commit to keszybz/systemd that referenced this pull request Mar 13, 2018
keszybz added a commit to keszybz/systemd that referenced this pull request Mar 14, 2018
keszybz added a commit to keszybz/systemd that referenced this pull request Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

DHCP client must ignore default route option if classless static route option is set
5 participants