Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHCP client must ignore default route option if classless static route option is set #5695

Closed
1 of 2 tasks
ignatk opened this issue Apr 3, 2017 · 1 comment · Fixed by #6885
Closed
1 of 2 tasks

DHCP client must ignore default route option if classless static route option is set #5695

ignatk opened this issue Apr 3, 2017 · 1 comment · Fixed by #6885
Labels
bug 🐛 Programming errors, that need preferential fixing dhcp network

Comments

@ignatk
Copy link
Contributor

ignatk commented Apr 3, 2017 •
edited
Loading

Submission type

  • Bug report
  • Request for enhancement (RFE)

systemd version the issue has been seen with

231 (but according to the source should apply to master)

Used distribution

Debian Jessie (with backports)

In case of bug report: Expected behaviour you didn't see

According to RFC 3442:

If the DHCP server returns both a Classless Static Routes option and
a Router option, the DHCP client MUST ignore the Router option.

In case of bug report: Unexpected behaviour you saw

When DHCP server is configured to send both SD_DHCP_OPTION_ROUTER and SD_DHCP_OPTION_CLASSLESS_STATIC_ROUTE, DHCP client in systemd-networkd sets them both as routes

In case of bug report: Steps to reproduce the problem

Configure DHCP server as following (example for dnsmasq):

dhcp-option=3,<default gateway>
dhcp-option=121,<some cidr>,<gateway>
@poettering poettering added bug 🐛 Programming errors, that need preferential fixing dhcp network labels Apr 4, 2017
ssahani pushed a commit to ssahani/systemd that referenced this issue Sep 21, 2017
networkd: DHCP client - ignore default route if classless static rout…
df35b07 
…e is set.

According to RFC 3442:

If the DHCP server returns both a Classless Static Routes option and
a Router option, the DHCP client MUST ignore the Router option.

This work fixes systemd#5695.
@ssahani ssahani mentioned this issue Sep 21, 2017
Merged
@ssahani
Copy link
Contributor

ssahani commented Sep 22, 2017

Fix is waiting one #5695

@yuwata yuwata added the has-pr label Nov 1, 2017
ssahani pushed a commit to ssahani/systemd that referenced this issue Nov 21, 2017
networkd:DHCP-client ignore default route if classless static route i…
a9381b7 
…s set

According to RFC 3442:

If the DHCP server returns both a Classless Static Routes option and
a Router option, the DHCP client MUST ignore the Router option.

fixes systemd#5695.
keszybz pushed a commit that referenced this issue Nov 22, 2017
@ssahani @keszybz
networkd:DHCP-client ignore default route if classless static route i…
5f04a20 
…s set (#6885)

According to RFC 3442:

If the DHCP server returns both a Classless Static Routes option and
a Router option, the DHCP client MUST ignore the Router option.

fixes #5695.
@thierer thierer mentioned this issue Jan 3, 2018
Closed
@ssahani ssahani mentioned this issue Apr 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Programming errors, that need preferential fixing dhcp network
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

networkd: DHCP client - ignore default route if classless static rout… ssahani/systemd
4 participants
@ssahani @poettering @ignatk @yuwata