timesync: make poll interval configurable #7268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poettering
requested changes
Nov 7, 2017
man/timesyncd.conf.xml
Outdated
| @@ -103,10 +103,20 @@ | |||
|
|
|||
| <varlistentry> | |||
| <term><varname>RootDistanceMaxSec=</varname></term> | |||
| <listitem><para>Maximum acceptable root distance in seconds. | |||
| <listitem><para>Maximum acceptable root distance. Takes time (in seconds). | |||
There was a problem hiding this comment.
Maybe "Takes a time value (in seconds)"?
man/timesyncd.conf.xml
Outdated
| <term><varname>PollIntervalMinSec=</varname></term> | ||
| <term><varname>PollIntervalMaxSec=</varname></term> | ||
| <listitem><para>The minimum and maximum poll intervals for NTP messages. | ||
| Take time (in seconds). <varname>PollIntervalMinSec=</varname> must not be smaller than 16 seconds. |
poettering
added
the
reviewed/needs-rework 🔨
This adds PollIntervalMinSec= and PollIntervalMaxSec= to timesyncd.conf Closes systemd#7262.
|
@poettering Thanks. Updated. |
yuwata
removed
the
reviewed/needs-rework 🔨
|
lgtm. thanks! |
poettering
approved these changes
Nov 7, 2017
poettering
added
the
good-to-merge/waiting-for-ci 👍
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
PollIntervalMinSec=andPollIntervalMaxSec=to timesyncd.confCloses #7262.
I proposed this in #7215. But at that time no one requests these options, then I dropped them. After that, in #7262 @conqp requests max and min poll intervals configurable. So, I resubmit this.
Note that the relevant options exist in both chrony.conf and ntp.conf (
minpollandmaxpoll).