login: do not try to close session fd if it is -1 #9642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f270533 added a check in session_device_stop() whether the fd is valid. We should do the same in session_device_free(). In https://bugzilla.redhat.com/show_bug.cgi?id=1576347 we fail the assertion in close_nointr(). The code changes quite a bit since then, but not that part.
poettering
reviewed
Jul 18, 2018
| session_device_notify(sd, SESSION_DEVICE_RELEASE); | ||
| safe_close(sd->fd); | ||
| if (close_fd) | ||
| safe_close(sd->fd); |
There was a problem hiding this comment.
not sure i follow... safe_close() is a no-op anyway if sd->fd is negative, so what does this precisely change?
|
Pfff, there was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f270533 added a check in session_device_stop()
whether the fd is valid. We should do the same in session_device_free().
In https://bugzilla.redhat.com/show_bug.cgi?id=1576347 we fail the assertion
in close_nointr(). The code changes quite a bit since then, but not that part.