Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: parse boot parameters for an Anaconda inbibit parameter #42

Closed
cmurf opened this issue Jul 9, 2020 · 4 comments · Fixed by #43
Closed

RFE: parse boot parameters for an Anaconda inbibit parameter #42

cmurf opened this issue Jul 9, 2020 · 4 comments · Fixed by #43

Comments

@cmurf
Copy link

cmurf commented Jul 9, 2020

Currently Anaconda has its own built-in swap-on-zram implementation, which can be inhibited by 'inst.zram'. Since the plan is for that implementation to be obsoleted in favor of zram-generator, it might be nice to keep this option functional.

Igor's idea is for the generator to parse for 'inst.zram' or 'inst.nozram' and simply inhibit. And have anaconda requires 'zram-generator-defaults' so that it can by default depend on swap-on-zram being available unless inhibited by this option. That seems more elegant than my idea that Anaconda go to the trouble of stopping the service created by the generator.
https://www.redhat.com/archives/anaconda-devel-list/2020-July/msg00016.html

@poncovka
Copy link

poncovka commented Jul 9, 2020

Just a note, Anaconda supports the following variants:

inst.zram
inst.zram=on
inst.zram=1

It forces usage of zRAM swap for the installation process.

inst.zram=off
inst.zram=0

It disables usage of zRAM swap for the installation process.

I don't think that we support inst.nozram at this moment.

@keszybz
Copy link
Member

keszybz commented Jul 9, 2020

I'm confused which way zram-generator is supposed to go: should inst.zram inhibit zram-generator units?

@keszybz
Copy link
Member

keszybz commented Jul 9, 2020

Please check if #43 does what you need.

keszybz added a commit to keszybz/zram-generator that referenced this issue Jul 9, 2020
keszybz added a commit that referenced this issue Jul 10, 2020
@cmurf
Copy link
Author

cmurf commented Jul 13, 2020

Anaconda folks have decided to deprecate the inst.zram toggle. There may be some other use case to inhibit (troubleshooting?) via command line, but for now I'll close this issue.
https://www.redhat.com/archives/anaconda-devel-list/2020-July/msg00025.html

@cmurf cmurf closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants